return json strings from query results instead of dicts#154
Open
knQzx wants to merge 1 commit intoClickHouse:mainfrom
Open
return json strings from query results instead of dicts#154knQzx wants to merge 1 commit intoClickHouse:mainfrom
knQzx wants to merge 1 commit intoClickHouse:mainfrom
Conversation
mcp protocol requires tool results to be strings but execute_query and run_query were returning raw dicts, causing validation errors on every successful response. also fixes large UInt64 values getting corrupted since json.dumps with default=str serializes them properly fixes ClickHouse#141, helps with ClickHouse#111
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execute_query returns a dict but mcp protocol expects strings, so every successful query triggers a validation error. wrapped the return values with json.dumps. also added default=str which handles large UInt64 values that would otherwise lose precision
fixes #141, helps with #111