fix: resolve timezoneId in standalone builders so --fingerprint-timezone is not dropped#401
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
…one is not dropped Follow-up to CloakHQ#262/CloakHQ#265. buildArgs only reads `options.timezone` to emit --fingerprint-timezone. The launch* wrappers on the Playwright side resolve `timezoneId` -> `timezone` first, but two paths did not: - playwright buildLaunchOptions() is exported and used standalone, yet did not call resolveTimezone, so buildLaunchOptions({ timezoneId }) silently dropped the flag. - the puppeteer adapter's resolveArgs() (shared by launch / launchContext / launchPersistentContext) never resolved timezoneId at all, so the entire puppeteer surface dropped it. Add resolveTimezone() at the top of both. Tests cover timezoneId on the playwright standalone builder and the puppeteer launch path.
mvanhorn
force-pushed
the
fix/resolve-timezoneid-standalone-builders
branch
from
30f260a to
8ff63ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #265 (closed in favor of #262). You flagged that standalone callers passing
timezoneIdinstead oftimezonemiss--fingerprint-timezone. The code has since been refactored, so I traced the gap to where it actually lives now:buildLaunchOptions()(Playwright) is exported and used standalone but didn't callresolveTimezone, sobuildLaunchOptions({ timezoneId })silently dropped the flag.resolveArgs()— shared bylaunch/launchContext/launchPersistentContext— never resolvedtimezoneIdat all, so the entire puppeteer surface dropped it (broader than the Playwright side, where the launch wrappers already resolve it).resolveTimezone()added at the top of both. Tests covertimezoneIdon the Playwright standalone builder and the puppeteer launch path. Full suite green locally (422 passed).