fix: properly override template storage implementations for remote#1582
Merged
fix: properly override template storage implementations for remote#1582
Conversation
derklaro
reviewed
Jan 28, 2025
driver/impl/src/main/java/eu/cloudnetservice/driver/impl/template/RemoteTemplateStorage.java
Outdated
Show resolved
Hide resolved
Test Results 48 files ±0 48 suites ±0 1m 43s ⏱️ +23s Results for commit 1e82dc9. ± Comparison against base commit 8bfd442. This pull request removes 32 and adds 32 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
derklaro
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When api-impl splitting the RemoteTemplateStorage impl was not done correctly. Methods that handle file streams (in & out) were just called as usual RPCs which is not possible.
Modification
This PR overrides the specific method implementations and uses the chunked file transfer api to transfer filestreams.
Result
The template storage is working properly from the wrapper side.