Fix lower bound of cc crate#182
Merged
GuillaumeLagrange merged 1 commit intoJun 19, 2026
Merged
Conversation
konstin
added a commit
to pubgrub-rs/pubgrub
that referenced
this pull request
Jun 7, 2026
Old versions sometimes stop working on recent nightly, which broke the check on main. Using stable rust avoids this problem in the future. Also bump codspeed for the associated cc bump, to work around CodSpeedHQ/codspeed-rust#182.
konstin
added a commit
to pubgrub-rs/pubgrub
that referenced
this pull request
Jun 7, 2026
Old versions sometimes stop working on recent nightly, which broke the check on main. Using stable rust avoids this problem in the future. Also bump codspeed for the associated cc bump, to work around CodSpeedHQ/codspeed-rust#182.
Merging this PR will improve performance by 7.42%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |
konstin
added a commit
to astral-sh/pubgrub
that referenced
this pull request
Jun 7, 2026
Old versions sometimes stop working on recent nightly, which broke the check on main. Using stable rust avoids this problem in the future. Also bump codspeed for the associated cc bump, to work around CodSpeedHQ/codspeed-rust#182.
GuillaumeLagrange
approved these changes
Jun 19, 2026
Contributor
|
Thanks! Good catch |
Currently, the codspeed crate is declaring a dependency on cc 1.0, while using newer features. This is causing errors in minimal version checks in downstream crates. This PR dumps the cc minimal version and adds a minimal-versions CI check to enforce correct lower bounds. Signed-off-by: Guillaume Lagrange <guillaume@glagrange.eu>
36b90f9 to
d662f12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the codspeed crate is declaring a dependency on cc 1.0, while using newer features. This is causing errors in minimal version checks in downstream crates.
This PR dumps the cc minimal version and adds a minimal-versions CI check to enforce correct lower bounds.