Allow custom sort order for empty searches made in admin area#153
Open
r-a-y wants to merge 1 commit into
Open
Conversation
This notably allows the custom sort order to work when filtering by the 'All dates' or 'All Categories' dropdown filters on the Posts admin dashboard page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for the useful plugin. One of our users noticed that when using the "All dates" or "All Categories" dropdown filters on the Posts admin dashboard page, the custom sort order would not apply.
The issue is when using the "All dates" or "All Categories" dropdown filter, an empty
's'parameter is added to the URL querystring. Even if the's'parameter is empty, theis_search()function will still returntrue.is_search()is used by your plugin to determine whether the custom sort order is used or not:simple-custom-post-order/simple-custom-post-order.php
Lines 1451 to 1453 in a4cbfa9
So for this PR, I've made a small adjustment to the
is_search()line to see if thesparameter is empty or not. If it is empty, allow the custom sort to proceed. I've made it so this is only applied in the admin area to allow frontend searches to work as they have before, but feel free to make changes how you see fit.