fix: change 'green triangle' to 'blue triangle' in partial-execution docs#1248
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughUpdated Partial Execution documentation in English, Japanese, Korean, and Chinese to describe the qualifying toolbox triangle icon as blue instead of green. ChangesPartial Execution documentation
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…docs The Partial Execution feature button in Comfy Cloud is blue with a white triangle, not green. Updated all language versions (en, zh, ja, ko) to match the actual UI and example graphics. Fixes comment from dipSlope in discussion Comfy-Org#1246
e44e4bb to
e4ad301
Compare
There was a problem hiding this comment.
Actionable comments posted: 7
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ja/tutorials/utility/void-video-inpainting.mdx`:
- Line 128: Replace the incomplete heading `## 補` with `## 補足説明` in the
tutorial, and verify that the explanatory bullets previously associated with
this section were intentionally relocated and remain available in their new
location.
In `@ko/tutorials/utility/void-video-inpainting.mdx`:
- Line 112: SAM3 객체 프롬프트 설명의 어색한 표현인 “마스크할 무엇인지에 대한”을 “무엇을 마스크할지 나타내는 짧은
레이블입니다”처럼 자연스러운 한국어로 수정하세요.
- Line 135: Remove the incomplete duplicate bullet in the SAM3 prompt guidance,
or replace it with the complete localized sentence matching the guidance near
line 114; ensure the resulting documentation does not repeat or end abruptly at
“지정”.
- Line 6: Update the frontmatter `translationSourceHash` value in the
void-video-inpainting tutorial from `25eb2a18` to `e8e6c573` so it matches the
English source.
In `@zh/interface/features/partial-execution.mdx`:
- Line 31:
修改部分执行功能说明中的中文表述:将“需要满足,当前选中的节点是一个输出节点”改为语法完整、自然的句式,并将“工作箱”替换为准确的“工具箱”术语,同时保持原有操作步骤和含义不变。
In `@zh/tutorials/utility/void-video-inpainting.mdx`:
- Line 46: 将 void-video-inpainting
教程中的限制提示语“根本的分割错误”改为更自然、准确的“根本性的分割错误”,保持其余内容不变。
- Line 111: 将“要遮罩移除的对象描述”改为更自然清晰的表述,例如“需要通过遮罩移除的对象描述”,保持其余 SAM3 提示词说明和示例不变。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 290f417e-79ba-4db4-8e0a-881694bfde6d
📒 Files selected for processing (8)
interface/features/partial-execution.mdxja/interface/features/partial-execution.mdxja/tutorials/utility/void-video-inpainting.mdxko/interface/features/partial-execution.mdxko/tutorials/utility/void-video-inpainting.mdxtutorials/utility/void-video-inpainting.mdxzh/interface/features/partial-execution.mdxzh/tutorials/utility/void-video-inpainting.mdx
| - **プロンプト作成のコツ** — 削除後、シーンが自然に見えるべき姿を説明し、削除そのものを説明しないでください | ||
| - **ネガティブプロンプト** は、繰り返し現れる欠陥(ウォーターマーク、ぼやけ、余分な手足など)が見られる場合にのみ使用してください | ||
| - **2パスワークフロー** — テンプレートは Pass 1 から Pass 2 を自動実行します。テスト中は Pass 1 のみを実行して迅速に反復することもできます | ||
| ## 補 No newline at end of file |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Restore the incomplete section heading.
Line [128] renders as ## 補, which is an unfinished heading and leaves the auxiliary guidance hanging. Restore ## 補足説明 and confirm that the removed explanatory bullets were intentionally relocated.
Proposed fix
-## 補
+## 補足説明📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## 補 | |
| ## 補足説明 |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ja/tutorials/utility/void-video-inpainting.mdx` at line 128, Replace the
incomplete heading `## 補` with `## 補足説明` in the tutorial, and verify that the
explanatory bullets previously associated with this section were intentionally
relocated and remain available in their new location.
| sidebarTitle: "VOID 비디오 인페인팅" | ||
| description: "Netflix가 개발한 VOID 비디오 인페인팅 모델을 사용해 비디오에서 객체를 제거하는 방법을 알아보세요. ComfyUI에서 기본적으로 지원됩니다." | ||
| translationSourceHash: aaa47b1e | ||
| translationSourceHash: 25eb2a18 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
python - <<'PY'
import hashlib
import pathlib
import re
en = pathlib.Path("tutorials/utility/void-video-inpainting.mdx").read_bytes()
ko = pathlib.Path("ko/tutorials/utility/void-video-inpainting.mdx").read_text()
expected = hashlib.sha256(en).hexdigest()[:8]
actual = re.search(r"translationSourceHash:\s*([a-f0-9]{8})", ko).group(1)
print(f"expected={expected} actual={actual}")
assert expected == actual
PYRepository: Comfy-Org/docs
Length of output: 275
Update the translation hash translationSourceHash is stale here; it should be e8e6c573 to match the English source.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ko/tutorials/utility/void-video-inpainting.mdx` at line 6, Update the
frontmatter `translationSourceHash` value in the void-video-inpainting tutorial
from `25eb2a18` to `e8e6c573` so it matches the English source.
| - **음성 프롬프트** — 선택적 아티팩트 방지 목록; 비워둘 수도 있습니다 | ||
| - **SAM3 객체 프롬프트** — 마스크할 **무엇인지**에 대한 짧은 레이블입니다. SAM3는 의미적 이해를 통해 대상 객체의 세그멘테이션 마스크를 생성합니다. | ||
| - **네거티브 프롬프트** — 선택적 아티팩트 방지 목록; 비워둘 수도 있습니다 | ||
| - **SAM3 객체 프롬프트** — 마스크할 **무엇인지**에 대한 짧은 레이블입니다. SAM3는 의미적 이해를 통해 대상 객체의 세그멘테이션 마스크를 자동으로 생성합니다. 마스크를 직접 그리거나 업로드할 필요가 없습니다. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the SAM3 prompt phrasing.
마스크할 무엇인지에 대한 is grammatically awkward. Use wording such as 무엇을 마스크할지 나타내는 짧은 레이블입니다.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ko/tutorials/utility/void-video-inpainting.mdx` at line 112, SAM3 객체 프롬프트 설명의
어색한 표현인 “마스크할 무엇인지에 대한”을 “무엇을 마스크할지 나타내는 짧은 레이블입니다”처럼 자연스러운 한국어로 수정하세요.
| - **프롬프트 작성 팁** — 제거된 이후의 장면이 자연스럽게 보이는 모습을 묘사하세요. 제거 자체가 아니라요. | ||
| - **음성 프롬프트 사용**은 반복적인 결함(워터마크, 흐릿함, 과다한 팔다리)이 보일 때만 사용하세요. | ||
| - **2회 통과 워크플로우** — 템플릿은 1회 통과 후 자동으로 2회 통과를 실행합니다; 테스트 중 더 빠른 반복을 위해 1회 통과만 실행할 수도 있습니다. | ||
| - SAM3 프롬프트의 최대 토큰 수는 **32**입니다. 여러 대상을 별도로 프롬프트하려면 쉼표로 구분하고, 각 프롬프트당 감지되는 최대 객체 수를 지정 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Remove or complete the dangling duplicate bullet.
Line [135] repeats the token guidance from line [114] but ends mid-sentence at 지정. The bullet stumbles before reaching the reader; remove it or restore the complete localized guidance.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ko/tutorials/utility/void-video-inpainting.mdx` at line 135, Remove the
incomplete duplicate bullet in the SAM3 prompt guidance, or replace it with the
complete localized sentence matching the guidance near line 114; ensure the
resulting documentation does not repeat or end abruptly at “지정”.
|  | ||
|
|
||
| 要使用部分执行功能,需要满足,当前选中的节点是一个输出节点,如保存或者预览节点,当对应的节点符合条件时,选中节点后选择工作箱上的按钮会显示为绿色三角形图标,点击该图标即可运行部分工作流 | ||
| 要使用部分执行功能,需要满足,当前选中的节点是一个输出节点,如保存或者预览节点,当对应的节点符合条件时,选中节点后选择工作箱上的按钮会显示为蓝色三角形图标,点击该图标即可运行部分工作流 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
修正中文说明的语法和工具箱术语。
“需要满足,当前选中的节点是”句式不完整,“工作箱”也不准确地表达了 toolbox。建议改为:
建议修改
-要使用部分执行功能,需要满足,当前选中的节点是一个输出节点,如保存或者预览节点,当对应的节点符合条件时,选中节点后选择工作箱上的按钮会显示为蓝色三角形图标,点击该图标即可运行部分工作流
+要使用部分执行功能,需要满足以下条件:当前选中的节点必须是输出节点,例如保存节点或预览节点。符合条件时,选中节点后,工具箱中的按钮会显示为蓝色三角形图标。点击该图标即可运行部分工作流。📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| 要使用部分执行功能,需要满足,当前选中的节点是一个输出节点,如保存或者预览节点,当对应的节点符合条件时,选中节点后选择工作箱上的按钮会显示为蓝色三角形图标,点击该图标即可运行部分工作流 | |
| 要使用部分执行功能,需要满足以下条件:当前选中的节点必须是输出节点,例如保存节点或预览节点。符合条件时,选中节点后,工具箱中的按钮会显示为蓝色三角形图标。点击该图标即可运行部分工作流。 |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@zh/interface/features/partial-execution.mdx` at line 31,
修改部分执行功能说明中的中文表述:将“需要满足,当前选中的节点是一个输出节点”改为语法完整、自然的句式,并将“工作箱”替换为准确的“工具箱”术语,同时保持原有操作步骤和含义不变。
| - **双阶段优化** — Pass 2 提供了更优的时间稳定性(更少的抖动和闪烁),尤其适用于长片段或纹理复杂的背景 | ||
|
|
||
| > **限制:** 模糊的遮罩、杂乱的运动或占据画面大部分的物体可能仍会产生不理想的结果——提示词无法修正根本的分割错误。 | ||
| > **限制:** 模糊的遮罩、杂乱的运动或占据画面大部分的物体可能仍会产生不理想的结果:提示词无法修正根本的分割错误。 |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use more natural Chinese wording for the segmentation limitation.
根本的分割错误 is awkward here. Use 根本性的分割错误 to make the limitation clearer.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~46-~46: 动词的修饰一般为‘形容词(副词)+地+动词’。您的意思是否是:模糊"地"遮
Context: ...更少的抖动和闪烁),尤其适用于长片段或纹理复杂的背景 > 限制: 模糊的遮罩、杂乱的运动或占据画面大部分的物体可能仍会产生不理想的结果:提示词无法修正根...
(wb4)
[uncategorized] ~46-~46: 动词的修饰一般为‘形容词(副词)+地+动词’。您的意思是否是:根本"地"分割
Context: ...罩、杂乱的运动或占据画面大部分的物体可能仍会产生不理想的结果:提示词无法修正根本的分割错误。 ## VOID 视频修复工作流 ### 1. 工作流文件下载 ...
(wb4)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@zh/tutorials/utility/void-video-inpainting.mdx` at line 46, 将
void-video-inpainting 教程中的限制提示语“根本的分割错误”改为更自然、准确的“根本性的分割错误”,保持其余内容不变。
Source: Linters/SAST tools
| - **SAM3 目标提示词** — 简短的**要遮罩移除**的对象描述。SAM3 通过语义理解为目标物体创建分割遮罩 | ||
| - 示例:`person in blue jacket`、`red cup on table` | ||
| - SAM3 提示词上限为 **32 个 token**,多个目标用逗号分隔,用 `:N` 指定每个提示检测的物体数量:`eye:2, window panels:4` | ||
| - **SAM3 目标提示词** — 简短的**要遮罩移除**的对象描述。SAM3 通过语义理解为目标物体自动创建分割遮罩。您无需手动绘制或上传遮罩。SAM3 提示词上限为 **32 个 token**,多个目标用逗号分隔,用 `:N` 指定每个提示检测的物体数量:`eye:2, window panels:4` |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Clarify the SAM3 target description.
要遮罩移除的对象描述 is unnatural and may slow readers down. Prefer 需要通过遮罩移除的对象描述 or equivalent wording.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@zh/tutorials/utility/void-video-inpainting.mdx` at line 111,
将“要遮罩移除的对象描述”改为更自然清晰的表述,例如“需要通过遮罩移除的对象描述”,保持其余 SAM3 提示词说明和示例不变。
Summary
The Partial Execution feature button in Comfy Cloud is blue with a white triangle, not green. Updated all language versions (en, zh, ja, ko) to match the actual UI and graphics.
Files Changed
interface/features/partial-execution.mdx(en)zh/interface/features/partial-execution.mdxja/interface/features/partial-execution.mdxko/interface/features/partial-execution.mdxSource
Fixes issue reported by dipSlope in discussion comment
Checklist