Use os.path.join for path operations to avoid trailing slashes#5
Open
michael-hoss wants to merge 1 commit into
Open
Use os.path.join for path operations to avoid trailing slashes#5michael-hoss wants to merge 1 commit into
os.path.join for path operations to avoid trailing slashes#5michael-hoss wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I set my own paths in
GeneralConfigurationusingos.path.joincommands, there won't be trailing/, e.g.However, without the trailing
/, the path concatenation in the propertiespath_scenarioorpath_outputbreaks.Hence, I suggest avoiding trailing
/(as these would get eliminated inos.path.normpath, too), and usingos.path.joinwhenever possible.Are there further locations that would need adaptation?