-
Notifications
You must be signed in to change notification settings - Fork 775
Sle16 dconf gnome patch #14366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Sle16 dconf gnome patch #14366
Conversation
|
Skipping CI for Draft Pull Request. |
|
/packit build |
…and use dconf_gdm_dirvariable for location
6587ae0 to
f7184bd
Compare
products/ubuntu2204/product.yml
Outdated
| sssd: sssd-common | ||
| openssl-pkcs11: libpam-pkcs11 | ||
|
|
||
| dconf_gdm_dir: "local.d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This overrides the default setting gdm.d and could break a few rules which need to have settings defined in the gdm profile/database.
If I recall correctly, some settings need to be defined in gdm/gdm and others in user/local profile/database in Ubuntu:
- dconf_gnome_banner_enabled (gdm/gdm)
- dconf_gnome_disable_user_list (gdm/gdm)
- dconf_gnome_disable_automount (user/local)
- dconf_gnome_screensaver_idle_delay (user/local)
Can you check if that's the case on SLE? It might be better to use another variable, e.g. dconf_user_dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now in SLE we use only one system account/profile, so thanks for the feedback. Will revert the patch for ubuntu platform, to behave as before.
|
@teacup-on-rockingchair: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description:
Rationale:
Review Hints: