Fix for CGB-13 (Unsolicited PeerList Responses Can Amplify into CPU/IO Exhaustion and Liveness Degradation)

[rbaconcordium]

Purpose

When sending peer list response, limit the vector size for type Node

Changes

in send_peer_list_resp, for PeerType:Node, when building the vector of peer nodes, collect up to the PEER_LIST_LIMIT

Checklist

• [ x ] My code follows the style of this project.
• [ x ] The code compiles without warnings.
• [ x ] I have performed a self-review of the changes.
• [ x ] I have documented my code, in particular the intent of the
  hard-to-understand areas.
• (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

• link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf

• I accept the above linked CLA.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.51%. Comparing base (9b14f2c) to head (7614f90).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
concordium-node/src/connection/mod.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1550   +/-   ##
=======================================
  Coverage   60.50%   60.51%           
=======================================
  Files         314      314           
  Lines       66141    66142    +1     
  Branches     2924     2922    -2     
=======================================
+ Hits        40021    40024    +3     
  Misses      23196    23196           
+ Partials     2924     2922    -2     

Files with missing lines	Coverage Δ
concordium-node/src/connection/mod.rs	54.62% <0.00%> (-0.13%)	⬇️

... and 3 files with indirect coverage changes