fix: evm typed data signing for non-standard eip712 payloads - #190
Merged
Conversation
🦋 Changeset detectedLatest commit: a740a39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
muzaffarbhat07
requested changes
Aug 19, 2026
muzaffarbhat07
approved these changes
Aug 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Signing EIP-712 typed data on the X1 fails for dapps like Hyperliquid (https://app.hyperliquid.xyz). Connecting via WalletConnect and signing the "Establish connection" request (`eth_signTypedData_v4`) never completes.
Root cause is three defects in the typed-data struct encoder (`packages/app-evm/src/utils/signTypeDataProcessor.ts`):
Fix
Verification
Note: the X0 path (`ethers.TypedDataEncoder` on the host) already handled these payloads; this brings the X1 path to parity. On-device E2E against app.hyperliquid.xyz is pending a hardware pass.
🤖 Generated with Claude Code