Add affine geometry computations and improve Quick hull full dimensionality test - #1803
Merged
dcoeurjo merged 120 commits intoNov 21, 2025
Merged
Conversation
…basis and update tests
Member
|
/builddoc |
|
The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-pr/pr1803/index.html |
dcoeurjo
reviewed
Oct 25, 2025
dcoeurjo
left a comment
dcoeurjo
left a comment
Member
There was a problem hiding this comment.
Just a first batch on the interfaces/doc. Nice PR
Member
Author
|
Thanks for the first batch of suggestions. I have updated the code accordingly. |
Member
Author
|
/builddoc |
|
The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-pr/pr1803/index.html |
dcoeurjo
reviewed
Nov 6, 2025
dcoeurjo
left a comment
dcoeurjo
left a comment
Member
There was a problem hiding this comment.
Thx again.. Couple of comments but we are good to go.
dcoeurjo
self-requested a review
November 21, 2025 11:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR makes computations of lattice convex hulls more robust in arbitrary dimension, while adding different functionalities: affine geometry, affine basis, convex hull of not full dimensional sets of points. As a result, you can compute the convex hull of a set of points in Z^d, whatever it's spanned affine k-dimensional space (see GenericLatticeConvexHull).
Checklist