Conversation
Refactor all proofs under Utils/EGraph so that every lemma characterizing a state-monad computation is stated with the `vc` combinator (Utils/VC.v) instead of being written out with raw primitives (`match c e with (_,e')`, `snd (c e)`, `c e = (a,e')`), and remove unused lemma arguments. Converted lemmas (state arg folded into vc's bound state) across Semantics, QueryOpt, QueryOptSound, SemanticsAreUnified, SemanticsExecConst, SemanticsProcessErule, SemanticsSaturate, SemanticsUnionSem, SemanticsRebuildCanon, SemanticsLSurvive; e.g. saturate_until_sound, run1iter_sound, process_erule_sound, exec_*_sound, are_unified_*_sound, clauses_to_instance_*, hash_clause_*, compile_*, force_uf_*, find_roots_mono, find_returns_root, rebuild_canon, etc. Unused arguments removed (e.g. rebuild_sound's Pre, duplicate model_ok hypotheses, alloc_opaque_analyses_cover's order hypotheses). Consumer call sites in Pyrosome/Tools/EGraph (AddCtxInversion, ReducingCong, AdapterGlue) adapted to the new signatures; remaining consumers compile unchanged since the vc form is definitionally equal when the state arg was last. No new admits/axioms; Utils/EGraph rebuilds from scratch and the full Pyrosome/Tools/EGraph tree builds green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor all proofs under Utils/EGraph so that every lemma characterizing a state-monad computation is stated with the
vccombinator (Utils/VC.v) instead of being written out with raw primitives (match c e with (_,e'),snd (c e),c e = (a,e')), and remove unused lemma arguments.