ex-3615-add-filtering-by-cloud-event-id-to-fetch-api#28
Merged
Allyson-English merged 2 commits intomainfrom May 20, 2025
Merged
Conversation
elffjs
approved these changes
May 20, 2025
| Source: getStringValue(protoOptions.GetSource()), | ||
| Producer: getStringValue(protoOptions.GetProducer()), | ||
| Extras: getStringValue(protoOptions.GetExtras()), | ||
| ID: getStringValue(protoOptions.GetId()), |
Member
There was a problem hiding this comment.
I'm a little confused about what actually happens to this option. Where does it get processed?
| google.protobuf.StringValue extras = 10; | ||
|
|
||
| // ID of the event to filter. | ||
| google.protobuf.StringValue id = 11; |
Member
There was a problem hiding this comment.
Two things to think about:
- Do you want to let people pull multiple documents at once? That is, is it good for this to be a list?
- Do we want to require people to specify source if they do choose to specify an id? My sense is that ids are just not meaningful across sources.
Member
There was a problem hiding this comment.
Ah, I think you're following the existing pattern. I guess this is fine.
Contributor
There was a problem hiding this comment.
Yeah this is something I want to go back and add to all parameters someday we just have yet to have a need for it.
KevinJoiner
approved these changes
May 20, 2025
Allyson-English
deleted the
ex-3615-add-filtering-by-cloud-event-id-to-fetch-api-B
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.