Fix: Add close() method to BaseAlgorithm to prevent memory leaks#2193
Open
RPalmr wants to merge 3 commits intoDLR-RM:masterfrom
Open
Fix: Add close() method to BaseAlgorithm to prevent memory leaks#2193RPalmr wants to merge 3 commits intoDLR-RM:masterfrom
RPalmr wants to merge 3 commits intoDLR-RM:masterfrom
Conversation
added 2 commits
November 19, 2025 14:31
Introduces a `close()` method in BaseAlgorithm to explicitly clean up resources. This method closes the environment, deletes the policy and rollout buffer objects, and calls `torch.cuda.empty_cache()` and `gc.collect()`. This prevents increasing memory usage and Out-of-Memory (OOM) errors in sequential training loops, relative to DLR-RM#1966.
Introduces a `close()` method in BaseAlgorithm to explicitly clean up resources. This method closes the environment, deletes the policy and rollout buffer objects, and calls `torch.cuda.empty_cache()` and `gc.collect()`. This prevents increasing memory usage and Out-of-Memory (OOM) errors in sequential training loops, relative to DLR-RM#1966.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add close() method to BaseAlgorithm to prevent memory leaks #1966
Description
Introduces a
close()method in BaseAlgorithm to explicitly clean up resources. This method closes the environment, deletes the policy and rollout buffer objects, and callstorch.cuda.empty_cache()andgc.collect().This prevents increasing memory usage and Out-of-Memory (OOM) errors in sequential training loops, relative to #1966.
Motivation and Context
Types of changes
Checklist
make format(required)make check-codestyleandmake lint(required)make pytestandmake typeboth pass. (required)make doc(required)Note: You can run most of the checks using
make commit-checks.Note: we are using a maximum length of 127 characters per line