Fix some issues with soil layer properties#152
Open
chporter wants to merge 3 commits intoDSSAT:developfrom
Open
Fix some issues with soil layer properties#152chporter wants to merge 3 commits intoDSSAT:developfrom
chporter wants to merge 3 commits intoDSSAT:developfrom
Conversation
added 3 commits
February 19, 2026 15:07
- if DUL > SAT - 0.01, increase SAT - if LL > DUL - 0.01, decrease LL - differences are small except for CAMO900010 used in GLOB1632.LTX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rules:
The resulting model output differences are small except for CAMO900010 used in GLOB1632.LTX treatments 3, 11, 21, and 29. We might need to recalibrate this one (?).
In profile *IB00740011 in SOIL.SOL, I think the DUL entered was a typo so I copied the value from the layer above. (See the last soil profile in the diff listing below.)