Don't take long lived pointers to a stack variable#224
Open
azonenberg wants to merge 14 commits intoDTolm:developfrom
Open
Don't take long lived pointers to a stack variable#224azonenberg wants to merge 14 commits intoDTolm:developfrom
azonenberg wants to merge 14 commits intoDTolm:developfrom
Conversation
…ssues. (glscopeclient always uses "C" locale except when pritning for display)
…safety issues. (glscopeclient always uses "C" locale except when pritning for display)" This reverts commit ef447fe.
…e lagging latest code on GitHub?
…o a stack variable in "app", it's actually constant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some gcc versions complain about this. It appears the value is never modified once written so I just made it a static rather than trying to figure out how to track long lived allocations.