This repository was archived by the owner on Feb 22, 2025. It is now read-only.
Add Unavailability_MarketDocument_parser and fix ZipParser bug.#21
Open
nberliner wants to merge 1 commit intoDarioHett:mainfrom
Open
Add Unavailability_MarketDocument_parser and fix ZipParser bug.#21nberliner wants to merge 1 commit intoDarioHett:mainfrom
nberliner wants to merge 1 commit intoDarioHett:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Unavailability_MarketDocument_parser allows you to parse 4.7.6. Fall-backs (see ENTSO-E API Guide).
I added checks in the
ParserFactoryto check thedocument_typefor theUnavailability_MarketDocumenttag. Please note that I added thedocument_types for theOutages_MarketDocument_Parser()to the best of my knowledge but cannot give a guarantee.I further reverted the changes to the
ZipParserthat were introduced with commit 0145930 . As it was implemented, theZipParserwas handing alist()down to theXMLParserwhich caused an error. IMHO it is better to handle the occurrence of multiple zip files in theZipParserdirectly.