Add Dynasty wrapper

[bstienen]

No description provided.

[bstienen]

Three questions:

1. @beastraban Can you give me write access to your fork? I have a couple of small improvements that I'd like to make to your code.
2. Is there a reason you seed the numpy random number generator?
3. Is there a reason you don't do anything with rstate and _rstate?

[beastraban]

I sent an invite. Hopefully the correct one ***@***.*** ***@***.***> 😊

[bstienen]

Great! It worked. Still the questions about rstate and _rstate, though. If there is a good reason for it, we'll leave it like this, but if not I think I'd prefer to not fix the seed (as this might bias results in repeated experiments).

[beastraban]

In the new class I’m currently writing, I have removed this, unless specifically asked by the user. � Actually, just change whatever. I’ll sync with the new changes once we are clear on what is required. � As it is now, I don’t think this class is so useful. �

…

-- Ira � From: Bob Stienen ***@***.***> Sent: Tuesday, May 24, 2022 2:41 PM To: DarkMachines/high-dimensional-sampling ***@***.***> Cc: Ira Wolfson ***@***.***>; Mention ***@***.***> Subject: Re: [DarkMachines/high-dimensional-sampling] Add Dynasty wrapper (PR #68) � Great! It worked. Still the questions about rstate and _rstate, though. If there is a good reason for it, we'll leave it like this, but if not I think I'd prefer to not fix the seed (as this might bias results in repeated experiments). — Reply to this email directly, view it on GitHub <#68 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIDJO62EUOCBRWPPX2HTNYLVLTE6FANCNFSM5WY4WB2A> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[bstienen]

I'm a bit hesitant in merging code into the framework that is not useful (otherwise the codebase becomes really messy really quickly). I'll leave the pull request open for now, so that you can still make changes to your code. Just for your information: I've moved it to the folder high-dimensional-sampling/posterior/dynastysampler.py.

[beastraban]

OK. I’ll also make efforts to clean up the code before submitting it (in the future).