Report firmware update result to the user #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this moment it contains: - DrainInput() - DrawGraphicPopUp() Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
This was referenced Jan 15, 2026
filipleple
reviewed
Jan 16, 2026
filipleple
requested changes
Jan 16, 2026
BeataZdunczyk
requested changes
Jan 16, 2026
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Unused at this point. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Trace various branches of capsule processing to report how handling of a capsule or its payload went. The report is displayed at the end of the second round of capsule processing or after the first one if it ends with a reboot. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
SergiiDmytruk
force-pushed
the
capsules-results
branch
from
3cf7773 to
0833326
Compare
SergiiDmytruk
commented
Jan 18, 2026
Member
Author
SergiiDmytruk
left a comment
SergiiDmytruk
left a comment
There was a problem hiding this comment.
In addition to the review comments:
- fixed a memory bug
- added reporting capsule result in one more place
- added displaying capsule GUIDs
- increased delay on success from 5 to 30 seconds
Member
Author
|
I meant to include new screenshots yesterday, but must have closed that tab before sending them. Updated look, this time next to serial output ( 
|
Member
it’s unclear which firmware version is currently runnig on a hardware. @SergiiDmytruk Instead of |
Member
|
Maybe simply |
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
SergiiDmytruk
force-pushed
the
capsules-results
branch
from
0833326 to
c2e30de
Compare
Member
Author
Member
@SergiiDmytruk , perfect, approved. |
BeataZdunczyk
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This amends capsule update code to collect some fairly high-level information about how things went, still this is more than one gets from capsule result variables and possibly even logs. The code takes into account possibility of multiple capsules (we don't know what a user of
fwupdcan do) and multiple payloads.The displaying part reuses the dialog implemented in #285 after making it generally available and also provides code for constructing dialogs which are then displayed as both text (for serial) and graphics (overrides the text on a display), so that both tests and users should be relatively happy. In the future, we could reuse this code for our other dialogs and have all of them look consistently.
Screenshots are available in Dasharo/dasharo-issues#1434 (comment).
coreboot PR: Dasharo/coreboot#826
issue: Dasharo/dasharo-issues#1434
ref: dsh-1127