Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the singleMachine batch system,
environmentcontains the saved contents ofos.environ.This code then effectively concatenates the original PATH saved in
environmentto the PATH inos.environ, which is equal. In the end, os.environ thus gets extended with its original contents.In my case, my PATH was quite long. After toil concatenated it several times to
os.environ,os.environcontained 7 times the original PATH. Later, an "Argument list too long" error occured while executing a simplestatcall.If
environment["PATH"]already containsos.environ["PATH"](which is also true ofos.environ["PATH"]is empty or if it equalsenvironment["PATH]), the concatenation is not needed, so we can skip it and avoid the "Argument list too long" error.Changelog Entry
To be copied to the draft changelog by merger:
Reviewer Checklist
issues/XXXX-fix-the-thingin the Toil repo, or from an external repo.camelCasethat want to be insnake_case.docs/running/{cliOptions,cwl,wdl}.rstMerger Checklist