Skip to content

Conversation

@mr-c
Copy link
Contributor

@mr-c mr-c commented Jan 7, 2026

Changelog Entry

To be copied to the draft changelog by merger:

  • use subtests from pytest 9.x

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passed tests, including the Gitlab tests, for the most recent commit in its branch.
  • Make sure the PR has been reviewed. If not, review it. If it has been reviewed and any requested changes seem to have been addressed, proceed.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

@mr-c mr-c force-pushed the native_pytest_subtests branch from 8ca1a32 to 0715a04 Compare January 7, 2026 13:15
@mr-c mr-c force-pushed the native_pytest_subtests branch from 0715a04 to ee765af Compare January 7, 2026 13:52
@mr-c mr-c changed the title use subtests from pytest (>= 9.0.1) if available use subtests from pytest 9.x Jan 7, 2026
@mr-c
Copy link
Contributor Author

mr-c commented Jan 8, 2026

Motivation: in Debian's development release we upgraded Pytest to version 9.x, which pytest-subtests plugin is not compatible with. It is a bit tedious to be compatible with both versions, so why not upgrade to Pytest 9.x properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants