Skip to content

[WP] Add a flag to properly send remediation status update#47819

Open
theop-dd wants to merge 1 commit intomainfrom
theop-dd/fix-iso-status-not-send-rel
Open

[WP] Add a flag to properly send remediation status update#47819
theop-dd wants to merge 1 commit intomainfrom
theop-dd/fix-iso-status-not-send-rel

Conversation

@theop-dd
Copy link
Contributor

What does this PR do?

Add a flag to properly send remediation status update

Motivation

Previously, as soon as a network isolation was loaded, we did not send an event to update the status after a reload because we considered it already done.

@theop-dd theop-dd requested a review from a team as a code owner March 13, 2026 14:40
@theop-dd theop-dd added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels Mar 13, 2026
@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Mar 13, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 13, 2026
@agent-platform-auto-pr
Copy link
Contributor

Files inventory check summary

File checks results against ancestor 912e257a:

Results for datadog-agent_7.78.0~devel.git.558.1d4b96a.pipeline.102380037-1_amd64.deb:

No change detected

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 912e257
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
docker_agent_amd64 +11.46 KiB (0.00% increase) 807.347 → 807.358 → 813.040
docker_agent_arm64 +10.48 KiB (0.00% increase) 810.057 → 810.067 → 819.570
docker_agent_jmx_amd64 +11.45 KiB (0.00% increase) 998.262 → 998.273 → 1003.920
docker_agent_jmx_arm64 +10.49 KiB (0.00% increase) 989.751 → 989.762 → 999.170
26 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 747.034 MiB
agent_deb_amd64_fips 705.346 MiB
agent_heroku_amd64 311.763 MiB
agent_rpm_amd64 747.017 MiB
agent_rpm_amd64_fips 705.330 MiB
agent_rpm_arm64 724.914 MiB
agent_rpm_arm64_fips 686.196 MiB
agent_suse_amd64 747.017 MiB
agent_suse_amd64_fips 705.330 MiB
agent_suse_arm64 724.914 MiB
agent_suse_arm64_fips 686.196 MiB
docker_cluster_agent_amd64 203.682 MiB
docker_cluster_agent_arm64 218.164 MiB
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.639 MiB
docker_dogstatsd_arm64 36.939 MiB
dogstatsd_deb_amd64 29.859 MiB
dogstatsd_deb_arm64 28.016 MiB
dogstatsd_rpm_amd64 29.859 MiB
dogstatsd_suse_amd64 29.859 MiB
iot_agent_deb_amd64 43.076 MiB
iot_agent_deb_arm64 40.138 MiB
iot_agent_deb_armhf 40.878 MiB
iot_agent_rpm_amd64 43.076 MiB
iot_agent_suse_amd64 43.076 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +14.79 KiB (0.01% increase) 174.467 → 174.481 → 177.700
agent_deb_amd64_fips +7.53 KiB (0.00% increase) 165.384 → 165.391 → 172.230
agent_heroku_amd64 neutral 75.170 MiB → 79.970
agent_rpm_amd64 -3.34 KiB (0.00% reduction) 176.466 → 176.463 → 180.780
agent_rpm_amd64_fips +31.91 KiB (0.02% increase) 168.063 → 168.095 → 173.370
agent_rpm_arm64 -61.21 KiB (0.04% reduction) 159.406 → 159.346 → 161.610
agent_rpm_arm64_fips +8.07 KiB (0.01% increase) 151.394 → 151.401 → 155.910
agent_suse_amd64 -3.34 KiB (0.00% reduction) 176.466 → 176.463 → 180.780
agent_suse_amd64_fips +31.91 KiB (0.02% increase) 168.063 → 168.095 → 173.370
agent_suse_arm64 -61.21 KiB (0.04% reduction) 159.406 → 159.346 → 161.610
agent_suse_arm64_fips +8.07 KiB (0.01% increase) 151.394 → 151.401 → 155.910
docker_agent_amd64 -18.72 KiB (0.01% reduction) 267.160 → 267.142 → 271.240
docker_agent_arm64 -14.18 KiB (0.01% reduction) 254.466 → 254.453 → 259.800
docker_agent_jmx_amd64 -10.41 KiB (0.00% reduction) 335.804 → 335.794 → 339.870
docker_agent_jmx_arm64 -16.16 KiB (0.00% reduction) 319.113 → 319.098 → 324.390
docker_cluster_agent_amd64 -9.28 KiB (0.01% reduction) 71.286 → 71.277 → 72.920
docker_cluster_agent_arm64 neutral 66.924 MiB → 68.220
docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
docker_dogstatsd_amd64 neutral 14.951 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.288 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.888 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.775 MiB → 7.710
dogstatsd_rpm_amd64 -2.23 KiB (0.03% reduction) 7.901 → 7.898 → 8.800
dogstatsd_suse_amd64 -2.23 KiB (0.03% reduction) 7.901 → 7.898 → 8.800
iot_agent_deb_amd64 neutral 11.355 MiB → 12.040
iot_agent_deb_arm64 neutral 9.670 MiB → 10.450
iot_agent_deb_armhf neutral 9.899 MiB → 10.620
iot_agent_rpm_amd64 neutral 11.373 MiB → 12.060
iot_agent_suse_amd64 neutral 11.373 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5f4e57e9-96aa-4ec9-bf7a-054a20edc5de

Baseline: 912e257
Comparison: 1d4b96a
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -3.43 [-6.42, -0.44] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +0.75 [-0.87, +2.37] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.29 [+0.11, +0.47] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.28 [+0.17, +0.39] 1 Logs
quality_gate_idle memory utilization +0.24 [+0.19, +0.29] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization +0.13 [+0.06, +0.21] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.12 [+0.07, +0.17] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.10 [-0.13, +0.33] 1 Logs
file_tree memory utilization +0.06 [+0.00, +0.12] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.19, +0.21] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.17, +0.18] 1 Logs
ddot_metrics_sum_delta memory utilization +0.00 [-0.17, +0.17] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.09, +0.09] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.10, +0.05] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.04 [-0.43, +0.36] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.47, +0.38] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.05 [-0.56, +0.47] 1 Logs
otlp_ingest_metrics memory utilization -0.18 [-0.34, -0.01] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.25 [-0.39, -0.11] 1 Logs
ddot_logs memory utilization -0.26 [-0.33, -0.19] 1 Logs
otlp_ingest_logs memory utilization -0.34 [-0.44, -0.24] 1 Logs
quality_gate_idle_all_features memory utilization -0.41 [-0.45, -0.38] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -1.07 [-1.30, -0.83] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -3.43 [-6.42, -0.44] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 728 ≥ 26
docker_containers_memory memory_usage 10/10 272.23MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 705 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 173.70MiB ≤ 175MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 487.12MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 206.18MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 352.34 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 407.20MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed component/system-probe internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant