Conversation
Codeowners resolved as |
This comment has been minimized.
This comment has been minimized.
3b4fb27 to
162dfb1
Compare
699ea6b to
6ee3c9a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ee3c9ae4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // libraries (faulthandler, Django, FastAPI) can overwrite them afterwards. | ||
| // Re-installing here ensures our handler is active when the sampling thread runs. | ||
| // Only do this once to avoid overwriting g_old_segv with our own handler. | ||
| const bool fast_copy_enabled = use_alternative_copy_memory(); |
There was a problem hiding this comment.
Report fast-copy status from active backend
fast_copy_enabled is derived from use_alternative_copy_memory() (the env var), but init_safe_copy() can still fall back to non-memcpy readers when init_segv_catcher() fails; in that scenario this field is emitted as true even though memcpy-based copying is not actually active. That makes the new metadata unreliable for diagnosing production behavior.
Useful? React with 👍 / 👎.
Description
https://datadoghq.atlassian.net/browse/PROF-13820
This PR adds new information in the Internal Metadata payload of profiles:
memcpy-basedcopy_memoryimplementation is enabedThis is meant to be used to check that there aren't any typically problematic cases in real-life workloads.