Draft
Conversation
We perform some general maintenance of the suitespecs to remove redundancy and correct granularity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We perform some general maintenance of the suitespecs to remove redundancy and correct granularity.
Bug fixes
tests/profiling/suitespec.yml: Removed full duplicate definitions of$harness,$setup,core, andbootstrapcomponents that were already defined intests/suitespec.yml. Becausesuitespec.pyusesdict.update()(last-write-wins), the profiling spec was silently overwriting the global core component with an incomplete version missingddtrace/internal/ipc.pyandddtrace/_logger.py, preventing those file changes from triggering any suite.tests/appsec/suitespec.yml: Fixedappsec_threats_tornadosuite which had@flaskinstead of@tornadoin its paths — a copy-paste error that meant changes to the tornado integration would never trigger the tornado appsec test suite.tests/suitespec.yml: Removed duplicatetests/suitespec.ymlentry in the$harnesscomponent paths.tests/contrib/suitespec.yml: Removed duplicate@llmobsinbotocoresuite and duplicate@asgiindjangosuite paths.tests/ci_visibility/suitespec.yml: Removedcoverage_utilscomponent which was an exact duplicate of thecoveragecomponent already defined intests/contrib/suitespec.yml(both pointed toddtrace/contrib/internal/coverage/*). Removed the now-redundant@coverage_utilsreferences frompytestand testing suites, which already had@coverage.Coverage improvements
tests/contrib/suitespec.yml: Added@graphqlto thegraphql:graphenesuite to make the dependency on thegraphqlintegration explicit.tests/contrib/suitespec.yml: Addedddtrace/contrib/internal/trace_utils.py,trace_utils_async.py, andtrace_utils_base.pyto thecontribcomponent. These shared internal utilities were previously not in any component — changes to them would silently fail to trigger any suite.tests/contrib/suitespec.yml: Addedddtrace/ext/sql.pyto thedbapicomponent (alongside the existingext/db.py). SQL metadata used by all DBAPI-backed integrations is now consistently grouped.Reduced trigger scope
tests/contrib/suitespec.yml: Narrowed thecontribcomponent from two broad wildcards (ddtrace/contrib/*andddtrace/ext/*) to an explicit list of genuinely shared infrastructure files. Previously, a change to any top-levelcontribfile (e.g.ddtrace/contrib/dbapi.py,ddtrace/contrib/flask_cache.py) or any ext file (e.g.ddtrace/ext/kafka.py) would trigger every suite that included@contrib. Now the component only covers files with no specific component of their own — the package inits, trace_utils, the propagation layer, and the handful of broadly-shared ext files (http.py,net.py,user.py,websocket.py). All other ext files remain covered by their specific components.Additional Notes
Changes assisted by Claude Code