Skip to content

Comments

chore: clean up suitespecs#16615

Draft
P403n1x87 wants to merge 1 commit intomainfrom
gab/chore/clean-up-suitespecs
Draft

chore: clean up suitespecs#16615
P403n1x87 wants to merge 1 commit intomainfrom
gab/chore/clean-up-suitespecs

Conversation

@P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Feb 20, 2026

Description

We perform some general maintenance of the suitespecs to remove redundancy and correct granularity.

Bug fixes

  • tests/profiling/suitespec.yml: Removed full duplicate definitions of $harness, $setup, core, and bootstrap components that were already defined in tests/suitespec.yml. Because suitespec.py uses dict.update() (last-write-wins), the profiling spec was silently overwriting the global core component with an incomplete version missing ddtrace/internal/ipc.py and ddtrace/_logger.py, preventing those file changes from triggering any suite.

  • tests/appsec/suitespec.yml: Fixed appsec_threats_tornado suite which had @flask instead of @tornado in its paths — a copy-paste error that meant changes to the tornado integration would never trigger the tornado appsec test suite.

  • tests/suitespec.yml: Removed duplicate tests/suitespec.yml entry in the $harness component paths.

  • tests/contrib/suitespec.yml: Removed duplicate @llmobs in botocore suite and duplicate @asgi in django suite paths.

  • tests/ci_visibility/suitespec.yml: Removed coverage_utils component which was an exact duplicate of the coverage component already defined in tests/contrib/suitespec.yml (both pointed to ddtrace/contrib/internal/coverage/*). Removed the now-redundant @coverage_utils references from pytest and testing suites, which already had @coverage.

Coverage improvements

  • tests/contrib/suitespec.yml: Added @graphql to the graphql:graphene suite to make the dependency on the graphql integration explicit.

  • tests/contrib/suitespec.yml: Added ddtrace/contrib/internal/trace_utils.py, trace_utils_async.py, and trace_utils_base.py to the contrib component. These shared internal utilities were previously not in any component — changes to them would silently fail to trigger any suite.

  • tests/contrib/suitespec.yml: Added ddtrace/ext/sql.py to the dbapi component (alongside the existing ext/db.py). SQL metadata used by all DBAPI-backed integrations is now consistently grouped.

Reduced trigger scope

  • tests/contrib/suitespec.yml: Narrowed the contrib component from two broad wildcards (ddtrace/contrib/* and ddtrace/ext/*) to an explicit list of genuinely shared infrastructure files. Previously, a change to any top-level contrib file (e.g. ddtrace/contrib/dbapi.py, ddtrace/contrib/flask_cache.py) or any ext file (e.g. ddtrace/ext/kafka.py) would trigger every suite that included @contrib. Now the component only covers files with no specific component of their own — the package inits, trace_utils, the propagation layer, and the handful of broadly-shared ext files (http.py, net.py, user.py, websocket.py). All other ext files remain covered by their specific components.

Additional Notes

Changes assisted by Claude Code

We perform some general maintenance of the suitespecs to remove
redundancy and correct granularity.
@P403n1x87 P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos labels Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant