chore(aiokafka): add instrumentation manifest - #19890
Conversation
Signed-off-by: evgenii.vasilev <evgenii.vasilev@datadoghq.com>
Codeowners resolved asResolved from the full PR diff against No remaining files require a CODEOWNERS review. |
Circular import analysis
|
Dependency direction analysis
|
🎉 All green!🧪 All tests passed 🔄 Datadog auto-retried 2 jobs - 2 passed on retry 🔗 Commit SHA: c9772b3 | Docs | View more details | Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61a10505c3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
BenchmarksBenchmark execution time: 2026-08-27 13:24:47 Comparing candidate commit 61a1050 in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 580 metrics, 10 unstable metrics, 1 known flaky benchmarks, 17 flaky benchmarks without significant changes.
|
61a1050 to
96773de
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
5bd6b96
into
main
…19923) ## Description Excludes integration `*.manifest.yaml` files from source distributions to minimize package size. The [Instrumentation Manifest RFC](https://docs.google.com/document/d/18za_vEcA-hH4IEwRhebDhoQxQKSylCtwMeVDB3rYM4Y/edit?usp=sharing) will introduce a colocated manifest for every tracer integration, as illustrated by [PR #19890](#19890). These manifests are repository metadata and are not required at runtime. Because `MANIFEST.in` grafts the entire `ddtrace` directory, the manifests would otherwise be included automatically in published sdists. Wheels already exclude them through the existing explicit package-data allowlist. This change does not affect runtime behavior or public APIs. ## Testing - Tested with `ddtrace/contrib/internal/aiokafka/aiokafka.manifest.yaml` file. - Confirmed the previous `manifest.in` rules included the `*.manifest.yaml` file. - Confirmed the new rule excludes it while retaining normal integration Python files. - `scripts/run-tests --list MANIFEST.in` found no applicable test suites. - `scripts/lint checks` passed. ## Risks Low. The rule only excludes files ending in `.manifest.yaml` under `ddtrace` from source distributions. The files remain available in the repository. ## Additional Notes No release note is required. Add the `changelog/no-changelog` label. Co-authored-by: brett.langdon <brett.langdon@datadoghq.com>
Description
Adds an instrumentation manifest for the aiokafka integration.
The manifest provides structured, machine-readable metadata describing the integration without requiring consumers such as the Integration Portal to parse tracer implementation code. It records:
aiokafkapackage and integration identityThis PR does not change runtime behavior or public APIs.
Testing
scripts/lint checkspassed.Risks
There is no runtime instrumentation risk because this change adds only a declarative YAML file.
The metadata could become stale if the aiokafka instrumentation changes without updating its manifest.
MANIFEST.incurrently grafts theddtracedirectory, so the manifest may be included in source distributions unless packaging excludes it separately. This PR intentionally does not change packaging behavior.