Skip to content

ci(build_base_venvs): let riot install the dev package on Python 3.15 (PROF-14439) - #19904

Open
vlad-scherbich wants to merge 2 commits into
vlad/py315-testrunner-cython-pinfrom
vlad/py315-riot-install
Open

ci(build_base_venvs): let riot install the dev package on Python 3.15 (PROF-14439)#19904
vlad-scherbich wants to merge 2 commits into
vlad/py315-testrunner-cython-pinfrom
vlad/py315-riot-install

Conversation

@vlad-scherbich

@vlad-scherbich vlad-scherbich commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

Delta vs #19907.

riot's install_dev_pkg runs pip install -e ., so pip enforces requires-python = ">=3.9,<3.15" and refuses the dev package on 3.15. This PR sets PIP_IGNORE_REQUIRES_PYTHON=1 only for the PYTHON_VERSION=3.15 arm of build_base_venvs. Published metadata stays <3.15.

Testing

Inspect the generated build_base_venvs before_script for PYTHON_VERSION=3.15 and confirm the ignore is set only on that arm.

Risks

None. 3.15-only env var; other matrix versions unchanged.

Additional Notes

No release note: CI chore, changelog/no-changelog. Base: #19907. Next: #19906.

@datadog-official

datadog-official Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 3 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | core/internal 4/6 — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-py | rust ci — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-py | download_dependency_wheels: [3.15.0rc1, 3.15]

View more details · View in GitLab

2 Test performance regressions detected

test_instrument_view_benchmark[py3.10] from test_span.py — 0s (+0s, +122%)   View in Datadog

test_instrument_view_benchmark[py3.14] from test_span.py — 0s (+0s, +186%)   View in Datadog

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 13 tests - 11 passed on retry View in Datadog

🚧 8 tests that failed were ignored due to quarantine View in Datadog

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 19654b8 | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Aug 27, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-28 19:13:22

Comparing candidate commit 19654b8 in PR branch vlad/py315-riot-install with baseline commit 23f857d in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 7 performance regressions! Performance is the same for 579 metrics, 10 unstable metrics, 2 known flaky benchmarks, 16 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+2.568µs; +2.696µs] or [+15.582%; +16.358%]

scenario:iastaspects-add_aspect

  • 🟥 execution_time [+8.443µs; +11.475µs] or [+8.379%; +11.388%]

scenario:iastaspects-strip_aspect

  • 🟥 execution_time [+81.990µs; +87.756µs] or [+28.796%; +30.822%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+121.040µs; +129.383µs] or [+30.110%; +32.186%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+38.158µs; +44.077µs] or [+27.052%; +31.248%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+635.457ns; +675.308ns] or [+23.363%; +24.828%]

scenario:tracer-small

  • 🟥 execution_time [+35.912µs; +37.796µs] or [+11.283%; +11.875%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-752.909ns; +711.347ns] or [-6.871%; +6.491%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-33.434ns; +33.022ns] or [-5.471%; +5.404%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1781.342ns; +1525.742ns] or [-10.380%; +8.891%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1444.898ns; +1158.472ns] or [-10.762%; +8.629%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-328.014ns; +325.180ns] or [-8.896%; +8.819%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-261.687ns; +251.384ns] or [-8.909%; +8.558%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-63.608ns; +82.247ns] or [-5.451%; +7.048%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-3698.135ns; +4163.219ns] or [-9.156%; +10.308%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-809.183ns; +737.487ns] or [-9.953%; +9.071%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-64.737µs; +52.873µs] or [-10.313%; +8.423%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:iastaspects-casefold_noaspect

  • 🟥 execution_time [+70.705µs; +74.616µs] or [+29.142%; +30.754%]

scenario:span-start

  • 🟥 execution_time [+1.191ms; +1.344ms] or [+8.518%; +9.612%]

Known flaky benchmarks without significant changes:

  • scenario:errortrackingflasksqli-baseline
  • scenario:flasksimple-iast-get
  • scenario:iastaspects-casefold_aspect
  • scenario:iastaspects-index_aspect
  • scenario:iastaspects-ljust_noaspect
  • scenario:iastaspects-lower_aspect
  • scenario:iastaspects-replace_aspect
  • scenario:iastaspects-swapcase_aspect
  • scenario:iastaspects-title_noaspect
  • scenario:iastaspects-translate_aspect
  • scenario:iastaspects-translate_noaspect
  • scenario:iastaspects-upper_noaspect
  • scenario:packagespackageforrootmodulemapping-cache_off
  • scenario:packagespackageforrootmodulemapping-cache_on
  • scenario:sethttpmeta-all-enabled
  • scenario:telemetryaddmetric-record-100-metrics

@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from 4d1c0d3 to d76a38e Compare August 27, 2026 21:11
vlad-scherbich added a commit that referenced this pull request Aug 27, 2026
Add (3, 15) to SUPPORTED_PYTHON_VERSIONS and opt in six venvs. Default
max stays 3.14 so uncapped suites do not mix 3.15 into 3.9-3.14 jobs.
requires-python is unchanged; 3.15 installs fail until #19904.
@vlad-scherbich
vlad-scherbich changed the base branch from main to vlad/py315-testrunner-cython-pin August 27, 2026 21:11
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against vlad/py315-testrunner-cython-pin using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

.gitlab/templates/build-base-venvs.yml                                  @DataDog/python-guild @DataDog/apm-core-python

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

1 similar comment
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 27, 2026

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 240 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 240 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.llmobs._integrations.langgraph -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.internal.opentelemetry.trace -×-> ddtrace.trace  (product:opentelemetry -> product:tracing, score=133)
ddtrace.llmobs._integrations.langchain -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.debugging._signal.model -×-> ddtrace.trace  (product:debugging -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 27, 2026

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 27, 2026

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 240 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 240 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.llmobs._integrations.pydantic_ai -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.internal.opentelemetry.span -×-> ddtrace.trace  (product:opentelemetry -> product:tracing, score=133)
ddtrace.internal.ci_visibility.git_client -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=133)
ddtrace.internal.ci_visibility.filters -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@vlad-scherbich vlad-scherbich changed the title ci(build_base_venvs): let riot install the dev package on Python 3.15 ci(build_base_venvs): let riot install the dev package on Python 3.15 (PROF-14439) Aug 27, 2026
@vlad-scherbich vlad-scherbich added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 27, 2026
@vlad-scherbich
vlad-scherbich marked this pull request as ready for review August 27, 2026 22:59
@vlad-scherbich
vlad-scherbich requested review from a team as code owners August 27, 2026 22:59
@vlad-scherbich
vlad-scherbich requested review from Yun-Kim and juanjux and removed request for a team August 27, 2026 22:59
vlad-scherbich added a commit that referenced this pull request Aug 27, 2026
Add (3, 15) to SUPPORTED_PYTHON_VERSIONS and opt in six venvs. Default
max stays 3.14 so uncapped suites do not mix 3.15 into 3.9-3.14 jobs.
requires-python is unchanged; 3.15 installs fail until #19904.
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-testrunner-cython-pin branch from 992d101 to d872a18 Compare August 28, 2026 14:08
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from faa10e0 to ff3b31d Compare August 28, 2026 14:08
vlad-scherbich added a commit that referenced this pull request Aug 28, 2026
Add (3, 15) to SUPPORTED_PYTHON_VERSIONS and opt in six venvs. Default
max stays 3.14 so uncapped suites do not mix 3.15 into 3.9-3.14 jobs.
requires-python is unchanged; 3.15 installs fail until #19904.
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-testrunner-cython-pin branch from d872a18 to 8b2e454 Compare August 28, 2026 14:57
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from ff3b31d to 1d86b3f Compare August 28, 2026 14:57
vlad-scherbich added a commit that referenced this pull request Aug 28, 2026
Add (3, 15) to SUPPORTED_PYTHON_VERSIONS and opt in six venvs. Default
max stays 3.14 so uncapped suites do not mix 3.15 into 3.9-3.14 jobs.
requires-python is unchanged; 3.15 installs fail until #19904.
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-testrunner-cython-pin branch from 8b2e454 to 5785062 Compare August 28, 2026 15:51
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from 1d86b3f to 32c9f29 Compare August 28, 2026 15:51
vlad-scherbich added a commit that referenced this pull request Aug 28, 2026
Add (3, 15) to SUPPORTED_PYTHON_VERSIONS and opt in six venvs. Default
max stays 3.14 so uncapped suites do not mix 3.15 into 3.9-3.14 jobs.
requires-python is unchanged; 3.15 installs fail until #19904.
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-testrunner-cython-pin branch from 5785062 to 7e222d3 Compare August 28, 2026 16:07
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from 32c9f29 to 801e339 Compare August 28, 2026 16:07
riot's install_dev_pkg runs a bare `pip install -e .`, so pip enforces the
requires-python bound in pyproject.toml and refuses the dev package on 3.15:

    ERROR: Package 'ddtrace' requires a different Python: 3.15.0 not in '<3.15,>=3.9'

That blocks the base venv before any test code runs. Setting
PIP_IGNORE_REQUIRES_PYTHON only for the 3.15 matrix entry lets the venv build
while leaving the published requires-python bound at <3.15, so we do not
advertise support we do not have. Supported versions satisfy the bound already
and never take the branch.
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-testrunner-cython-pin branch from 7e222d3 to 639f7b7 Compare August 28, 2026 18:34
@vlad-scherbich
vlad-scherbich requested a review from a team as a code owner August 28, 2026 18:34
@vlad-scherbich
vlad-scherbich force-pushed the vlad/py315-riot-install branch from 801e339 to 19654b8 Compare August 28, 2026 18:34
vlad-scherbich added a commit that referenced this pull request Aug 28, 2026
Add (3, 15) to SUPPORTED_PYTHON_VERSIONS and opt in six venvs. Default
max stays 3.14 so uncapped suites do not mix 3.15 into 3.9-3.14 jobs.
requires-python is unchanged; 3.15 installs fail until #19904.
vlad-scherbich added a commit that referenced this pull request Aug 28, 2026
#17849 wrapping is merging to main; hashes sharing jobs and pip
install -e . (#19904) are the remaining reasons MAX stays 3.14.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant