SDBM-2260 Make query error tracking optional, default true #22259
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edengorevoy
changed the title
edengorevoy
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
edengorevoy
force-pushed
the
eden.gorevoy/add-query-error-stats-option
branch
from
f1f05de to
5091666
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
edengorevoy
force-pushed
the
eden.gorevoy/add-query-error-stats-option
branch
from
5091666 to
fa30427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In SDBM-2260 we have a user who upgraded to Agent 7.73 and started seeing issues with performance related to the Query Errors query starting with
SUM(SUM_ERROR_RAISED), causing them to downgrade the agent. The query runtime ranges from 18s - 50s on their host. The query was introduced in this PR.There are no performance issues with this query in our integration environments, and on most of the hosts in that user's environment, so part of the investigation will be understanding why that particular host is seeing high runtimes. The current theory is that there is some contention on
performance_schemathat might be caused by RDS Performance Insights making queries to the same table. In the meantime this PR makes the query configurable, but default true, for users that are having issues with it.Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged