Skip to content

Conversation

@cbeauchesne
Copy link
Collaborator

@cbeauchesne cbeauchesne commented Jan 9, 2026

Motivation

Prevent lint discrepencies : if ever the node installed locally is not 18, there are some CLI changes. Kudos to @christophe-papazian who noticed the issue.

Changes

Use a docker command to perform nodejs lint (so we do not require node)

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

CODEOWNERS have been resolved as:

format.sh                                                               @DataDog/system-tests-core
utils/build/docker/nodejs/express/app.js                                @DataDog/dd-trace-js @DataDog/system-tests-core
utils/build/docker/nodejs/express/package.json                          @DataDog/dd-trace-js @DataDog/system-tests-core
utils/build/docker/nodejs/fastify/package.json                          @DataDog/dd-trace-js @DataDog/system-tests-core

@cbeauchesne cbeauchesne marked this pull request as ready for review January 9, 2026 14:34
@cbeauchesne cbeauchesne requested review from a team as code owners January 9, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants