Skip to content

Comments

chore(crashtracking): filter out crash pings for crash report SSI test#6361

Open
gyuheon0h wants to merge 4 commits intomainfrom
gyuheon0h/filter-out-ping
Open

chore(crashtracking): filter out crash pings for crash report SSI test#6361
gyuheon0h wants to merge 4 commits intomainfrom
gyuheon0h/filter-out-ping

Conversation

@gyuheon0h
Copy link
Contributor

@gyuheon0h gyuheon0h commented Feb 20, 2026

Motivation

Later versions of libdatadog crashtracker send crash pings. These can have siginfo tags if it is a crash from a Unix signal caused crash. We should filter those out.

For example, we have system-tests for dd-trace-js failing after upgrading to libdatadog v27

AssertionError: More than one crash report found
E       assert 2 == 1
E        +  where 2 = len([{'count': 1, 'is_crash': True, 'is_sensitive': True, 'level': 'ERROR', ...}, {'count': 1, 'is_crash': False, 'is_sensitive': False, 'level': 'DEBUG', ...}])

The debug log is a crash ping

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@gyuheon0h gyuheon0h requested a review from a team as a code owner February 20, 2026 18:15
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

CODEOWNERS have been resolved as:

tests/docker_ssi/test_docker_ssi_crash.py                               @DataDog/system-tests-core
utils/interfaces/_test_agent.py                                         @DataDog/system-tests-core

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e58270dbe

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant