Conversation
added 2 commits
February 20, 2026 17:30
Contributor
|
|
added 2 commits
February 20, 2026 17:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Dynamic Instrumentation's circuit breaker automatically disables probes that consume too much CPU time to protect application performance. The Ruby tracer recently added environment variable support for configuring the circuit breaker timeout.
This PR adds system tests for the circuit breaker feature:
DD_DYNAMIC_INSTRUMENTATION_CAPTURE_TIMEOUTfor Java/Ruby,DD_DYNAMIC_INSTRUMENTATION_CAPTURE_TIMEOUT_MSfor Node)@missing_featuredecorator for other languages)Related Ruby Tracer PR: DataDog/dd-trace-rb#5386
Changes
Added Environment Variables (
utils/_context/_scenarios/__init__.py)Added circuit breaker configuration to scenarios for cross-language support:
debugger_probes_snapshot: AddedDD_DYNAMIC_INSTRUMENTATION_CAPTURE_TIMEOUT="-1"(Java/Ruby) andDD_DYNAMIC_INSTRUMENTATION_CAPTURE_TIMEOUT_MS="-1"(Node) to disable circuit breaker during capture limits testsdebugger_circuit_breaker: New scenario with both variables set to"0"to trip circuit breaker immediately for testingNew Test (
tests/debugger/test_debugger_circuit_breaker.py)Added comprehensive circuit breaker test that:
ERRORstatusexceptionfield with circuit breaker message@missing_featuredecorator for other languagesNew Feature Decorator (
utils/_features.py)Added
@features.debugger_circuit_breakerdecorator withfeature_id=None- needs Feature Parity Dashboard registrationWorkflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is presentdebugger_circuit_breakerscenario