deps: bump posthog-telemetry to 4cd2256 (teardown SIGSEGV fix)#89
Merged
Conversation
The 0433745 pin can SIGSEGV at process exit: its atexit shutdown handler drains the telemetry queue, constructing new httplib Clients whose ctor regex (a function-local static, destroyed before the handler runs) is already dead. Deterministic crash reproduced in quack-oauth's DuckDB v1.5.3 statically-linked test binary (exit 139 after all tests pass); same mechanism applies to any consumer with events still queued at exit. New pin (DataZooDE/posthog-telemetry#4): Stop() discards pending tasks instead of draining them, and Instance() pre-warms httplib's statics before registering the atexit handler.
posthog-telemetry 0433745 reads the machine id from the IORegistry on macOS (IORegistryEntryFromPath, IORegistryEntryCreateCFProperty), which left the osx_arm64 extension link failing with undefined IOKit symbols. Link IOKit and CoreFoundation explicitly for both extension targets.
Contributor
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the shared
posthog-telemetrysubmodule from0433745to4cd2256(current posthog-telemetry main).Why
0433745can SIGSEGV at process exit: its atexit shutdown handler drains the telemetry queue, constructing new httplibClients whose URL-parsing regex — a function-local static already destroyed at that point — gets dereferenced dead. Reproduced deterministically in quack-oauth (DuckDB v1.5.3 statically-linked unittest binary, exit 139 after all tests pass; gdb stack in DataZooDE/posthog-telemetry#4). The same mechanism fires in any consumer with telemetry events still queued at exit.New pin
DataZooDE/posthog-telemetry#4:
Stop()discards pending tasks (no new network I/O once shutdown begins) andInstance()pre-warms httplib's function-local statics before registering the atexit handler.Verification
Part of the portfolio-wide sweep after DataZooDE/quack-oauth#8.
🤖 Generated with Claude Code
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.