Add parallel build support with -parallel and -jobs options#34
Open
arthurbdiniz wants to merge 1 commit intoDebian:masterfrom
Open
Add parallel build support with -parallel and -jobs options#34arthurbdiniz wants to merge 1 commit intoDebian:masterfrom
arthurbdiniz wants to merge 1 commit intoDebian:masterfrom
Conversation
stapelberg
requested changes
Aug 29, 2025
4d57a16 to
30878ea
Compare
stapelberg
requested changes
Sep 13, 2025
|
@arthurbdiniz Did you notice you got feedback on this? There are no comments from you so it is a bit unclear, but you did push changes. Perhaps you want to comment explicitly asking Michael to re-review, or press the arrow button thing? |
a2e398d to
98eaf62
Compare
This allows faster builds by utilizing multiple CPU cores. Signed-off-by: Arthur Diniz <arthurbdiniz@gmail.com>
98eaf62 to
e824d8e
Compare
Author
|
Pull Request updated, waiting for another review. |
stapelberg
approved these changes
Feb 3, 2026
| log.Printf("building %s failed: %v\n", src, result.err) | ||
| } | ||
|
|
||
| resultsMu.Lock() |
Contributor
There was a problem hiding this comment.
add defer resultsMu.Unlock() after this line and remove the explicit resultsMu.Unlock() below. It’s good style to defer the unlocking so that one can’t forget it in any code path below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces parallel package building to ratt.
-parallelenables parallel builds.-jobscontrols the number of concurrent workers (default: number of CPU cores, must be > 0).buildPackagesSequentialandbuildPackagesParallelhelpers.This allows faster builds by utilizing multiple CPU cores.
Example: