Optimize build_cartesian_ncc_matrix#331
Open
tjc0726 wants to merge 1 commit intoDedalusProject:masterfrom
Open
Optimize build_cartesian_ncc_matrix#331tjc0726 wants to merge 1 commit intoDedalusProject:masterfrom
tjc0726 wants to merge 1 commit intoDedalusProject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes
Product.build_cartesian_ncc_matrix()indedalus/core/arithmetic.pyto achieve speedup for problems with spatially varying coefficients (NCC).The key insight is to batch-accumulate sparse matrices instead of sequential addition, reducing sorting/deduplication overhead from O(n²) to O(n log n).
In my case
Benchmark: 2D Navier-Stokes with NCC, N=64
Numerical Verification
All fields match to machine precision (relative error < 1e-14):
here's my example using monkry patch, one can delete the patch to check the difference
example_ncc_flow_optimized.py