Skip to content

[sdp-transform] v3.0#75086

Merged
typescript-bot merged 2 commits into
DefinitelyTyped:masterfrom
Anidetrix:patch-1
Jun 8, 2026
Merged

[sdp-transform] v3.0#75086
typescript-bot merged 2 commits into
DefinitelyTyped:masterfrom
Anidetrix:patch-1

Conversation

@Anidetrix

@Anidetrix Anidetrix commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

clux/sdp-transform#104
https://github.com/clux/sdp-transform/blob/8e39bde153ecf10e0b9d885cff9bb58fafbb10bd/lib/parser.js#L71

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: Allow multiple a=msid attributes clux/sdp-transform#104
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@Anidetrix Anidetrix changed the title [sdp-transform] ParamsMap values can be undefined [sdp-transform] ParamMap values can be undefined Jun 6, 2026
@typescript-bot

typescript-bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

@Anidetrix Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75086,
  "author": "Anidetrix",
  "headCommitOid": "85d7c4efc1bfcdb03184ce65ee47a2421683c051",
  "mergeBaseOid": "ca65e20b1c0aba452e9be1407798945801c758f5",
  "lastPushDate": "2026-06-06T20:30:14.000Z",
  "lastActivityDate": "2026-06-08T00:38:40.000Z",
  "mergeOfferDate": "2026-06-08T00:37:03.000Z",
  "mergeRequestDate": "2026-06-08T00:38:40.000Z",
  "mergeRequestUser": "Anidetrix",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "sdp-transform",
      "kind": "edit",
      "files": [
        {
          "path": "types/sdp-transform/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/sdp-transform/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/sdp-transform/sdp-transform-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "loc",
        "muenchow",
        "ibc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "loc",
      "date": "2026-06-08T00:36:24.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 4640281136,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Jun 6, 2026
@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Jun 6, 2026
@typescript-bot

Copy link
Copy Markdown
Contributor

🔔 @loc @muenchow @ibc — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jun 6, 2026
@Anidetrix Anidetrix changed the title [sdp-transform] ParamMap values can be undefined [sdp-transform] Update to v3.0 Jun 7, 2026
@typescript-bot typescript-bot removed the Untested Change This PR does not touch tests label Jun 7, 2026
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Jun 7, 2026
@Anidetrix Anidetrix changed the title [sdp-transform] Update to v3.0 [sdp-transform] v3.0 Jun 7, 2026
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Jun 8, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board Jun 8, 2026
@Anidetrix

Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Jun 8, 2026
@typescript-bot typescript-bot merged commit cbb4e4b into DefinitelyTyped:master Jun 8, 2026
4 checks passed

@ibc ibc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. LGTM.

@Anidetrix Anidetrix deleted the patch-1 branch June 9, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

4 participants