Conversation
…ed provider + factory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NUnit occasionally failed in GitHub Actions with a
NullReferenceExceptioninCreatePlayertests when usingRepositoryManagerTestCases. The root cause was NUnit’s internal cloning/serialization behavior: complex objects returned byTestCaseSource can be cloned using
GetUninitializedObject, bypassing their constructors and producing partially-initialized instances (e.g., DI-managed repositories set to null).This happens before the test lifecycle begins and outside the test context, which explains why failures were intermittent and
only reproduced in CI.
This refactor replaces complex test case objects with a simple enum (
DatabaseProvider).IRepositoryManagerinstances are now created inside the test via a dedicated factory, guaranteeing:All tests were updated to use the new enum-based provider and factory pattern.