Skip to content

119 autotest for dpcca with chol2d mult#120

Merged
Sinitca-Aleksandr merged 4 commits intomainfrom
119-autotest-for-dpcca-with-chol2d_mult
Mar 19, 2026
Merged

119 autotest for dpcca with chol2d mult#120
Sinitca-Aleksandr merged 4 commits intomainfrom
119-autotest-for-dpcca-with-chol2d_mult

Conversation

@pipipyau
Copy link
Copy Markdown
Collaborator

No description provided.

@pipipyau pipipyau linked an issue Mar 18, 2026 that may be closed by this pull request
@pipipyau pipipyau marked this pull request as draft March 18, 2026 15:38
@pipipyau pipipyau marked this pull request as ready for review March 18, 2026 16:01
@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot bot commented Mar 18, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • research/multi_scale_fractional_generator.py.ipynb - Updated mfnoise call to generate 5 tracks (parameter change from 1 to 5), removed unused import, formatting changes
  • tests/test_dpcca.py - Added new test for DPCCA with chol2d correlation matrix verification

Verification Completed

I verified the following:

  1. The mfnoise function's 4th positional parameter is n_tracks (default=1), so changing from 1 track to 5 tracks is valid
  2. Both imported functions (generate_fbn from StatTools.generators and chol2d_mult from StatTools.generators.multi_scale_fractional_generator) exist in the codebase
  3. The dpcca function returns a 4-element tuple, so using _ to ignore unused return values is correct
  4. The new test properly verifies DPCCA's ability to recover correlation matrices imposed via chol2d_mult

The changes are functional and correct.

@Sinitca-Aleksandr Sinitca-Aleksandr merged commit feed184 into main Mar 19, 2026
12 checks passed
@Sinitca-Aleksandr Sinitca-Aleksandr added this to the Release 1.11.0 milestone Mar 19, 2026
@Sinitca-Aleksandr Sinitca-Aleksandr added the enhancement New feature or request label Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autotest for dpcca with chol2d_mult

2 participants