feat(normalization): validation error correction and delete some dupl…#25
Open
Ekyoz wants to merge 1 commit into
Open
feat(normalization): validation error correction and delete some dupl…#25Ekyoz wants to merge 1 commit into
Ekyoz wants to merge 1 commit into
Conversation
Ekyoz
requested review from
a team,
GuillaumeSachet,
Relixik,
thibaud-perrin and
xaviave
Ekyoz
added
the
Enhancement
Contributor
|
J'ai remarqué que l'enum SetupStatus est défini en double avec des valeurs différentes. |
Relixik
reviewed
Jan 21, 2026
xaviave
requested changes
Jan 26, 2026
xaviave
reviewed
Jan 28, 2026
Collaborator
xaviave
left a comment
xaviave
left a comment
There was a problem hiding this comment.
-
add overall the CEL instead of the pattern.
Only validations like this are easier via patterns due to the union:
(buf.validate.field).string.pattern = "^(missions:|setups:).*$" -
Most of the string.min_len are equal to the minimum length without chars after, should be
mandatory_str_length + 1. -
Quite a lot of validations missing too.
-
Add optional to field where the required is false.
-
still use
not_infor the enum instead ofdefined_only -
Big mistake with the deletion of ModuleStatus
Ekyoz
force-pushed
the
feat/validation-proto
branch
3 times, most recently
from
da14899 to
b01266c
Compare
- Create _dto files for Request/Response in each service. - Create _messages files that contain all the proto objects. - Create _enum files to define the enum of each service. - Update Request to add pagination if list of objects is required. - Update Response to match the bulk structure for all the responses. - Standardize/Add validation rules to all fields with CEL. - Standardize DTOs (Create/Delete/List/Search/Update/Upload). - Update Taskfile for better workflow and unifying with the others Taskfile.
Ekyoz
force-pushed
the
feat/validation-proto
branch
from
0120a64 to
ddd9561
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize all the proto file and delete duplicate.
Rename some enum for enchance understability.