feat(router): support inactive_class in Link #5410
Open
nerjs wants to merge 1 commit intoDioxusLabs:mainfrom
Open
feat(router): support inactive_class in Link #5410nerjs wants to merge 1 commit intoDioxusLabs:mainfrom
nerjs wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
- add inactive_class prop - append it when route is not active - add playwright test for SSR and SPA class switching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
inactive_classsupport to theLinkcomponent.Changes
inactive_classprop toLinkPropsinactive_classwhen the target route is not activeactive_classMotivation
When using utility-first CSS (e.g. Tailwind), classes often have equal specificity, so relying on override order can lead to unexpected results.
Providing
inactive_classenables explicit, mutually exclusive styling for active and inactive states without depending on CSS cascade.Tests
Fixes #5318