Initial sketch to use Docker Compose instead of commands to manage containers#38
Closed
Axodouble wants to merge 1 commit intoDokploy:mainfrom
Closed
Initial sketch to use Docker Compose instead of commands to manage containers#38Axodouble wants to merge 1 commit intoDokploy:mainfrom
Axodouble wants to merge 1 commit intoDokploy:mainfrom
Conversation
Contributor
|
Hello, I believe the compose you created is exactly the same as what we had in the script. In fact, we do not perform any health validation to check if the services are running correctly. In this PR, for now, I prefer to stick with what we currently have. If I decide to change it in the future, I would take your idea into consideration. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created this draft with the following message in Discord before:
I decided to use curl to download the docker compose from the website. (Which is probably better to actually put in the main Dokploy repo, but for sake of ease I put it here now) and from there on use the docker compose file to enable / disable the services if they already exist.
This should fix issues that could occur when reinstalling the application or collisions with the name.
So here is the pull request, please review, and would love to hear feedback.