Skip to content

Add webtastic.site hosting template#783

Merged
pawel-kow merged 4 commits intoDomain-Connect:masterfrom
fiskeben:webtastic.site
Feb 26, 2026
Merged

Add webtastic.site hosting template#783
pawel-kow merged 4 commits intoDomain-Connect:masterfrom
fiskeben:webtastic.site

Conversation

@fiskeben
Copy link
Contributor

@fiskeben fiskeben commented Feb 24, 2026

Description

Template for webtastic.site web host.

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Schema validated using JSON Schema template.schema
  • Template functionality checked using Online Editor
  • Template is checked using template linter
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.

  • digital signatures are used and syncPubKeyDomain specified (yes, warnPhishing is an option, but some providers reject such templates by policy, so signing shall be a default)
  • syncRedirectDomain is specified when intended to use redirect_uri parameter in the synchronous flow
  • no TXT record with SPF content (i.e. "v=spf1 ...") instead of using SPFM record type on APEX
    Not in use
  • txtConflictMatchingMode is set on TXT records which shall be unique on a label (like DMARC)
    Not in use
  • variables are set to the smallest scope needed (i.e. limit possibility to be misused to set any arbitrary record and conflict with other template). Too broad scope example: @ TXT "%verification%". Better usage: @ TXT "foo-verification=%verification%".
    Not in use
  • no variables as a host name to apply template on subdomain instead of standard host parameter
    Not in use
  • no explicit usage of %host% variable in host attribute
    Not in use
  • essential setting is used on records, which the user shall be able to change or remove manually later without dropping the whole template (like DMARC)

Example variable values

<-- to make review process easier please provide the whole testData object from the Online Editor after testing and using "Add as test" button. Hint: test also with "host" variable set. -->

 "testData": {
    "webtastic.site": {
      "variables": {
        "domain": "example.com"
      },
      "results": [
        {
          "type": "A",
          "name": "@",
          "ttl": 3600,
          "data": "34.36.194.199"
        },
        {
          "type": "CNAME",
          "name": "www",
          "ttl": 3600,
          "data": "example.com"
        }
      ]
    }
  }

@github-actions
Copy link

github-actions bot commented Feb 24, 2026

Linter OK:

Linter result for webtastic.site.hosting.json

@kerolasa
Copy link
Collaborator

Seems reasonable, but are you sure about not wanting sync flow support?

https://github.com/Domain-Connect/dc-template-linter/wiki/DCTL1029

Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill in the test data in the description.

@pawel-kow pawel-kow added the PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. label Feb 25, 2026
@pawel-kow
Copy link
Member

Also "we plan to add syncPubKeyDomain in a follow-up." is just more work for everyone. syncPubKeyDomain is strongly recommended from the start.

@fiskeben
Copy link
Contributor Author

OK, I've added syncPubKeyDomain and added support for it on my side. I also added the test case as requested.

@pawel-kow
Copy link
Member

perfect, now if you have syncPubKeyDomain set, warnPhishing is pointless

@pawel-kow pawel-kow added this pull request to the merge queue Feb 26, 2026
Merged via the queue into Domain-Connect:master with commit 62b4f2a Feb 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR description incomplete The PR description template was not filled in at all, altered or filled in improperly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants