Add webtastic.site hosting template#783
Merged
pawel-kow merged 4 commits intoDomain-Connect:masterfrom Feb 26, 2026
Merged
Conversation
|
Linter OK: |
Collaborator
|
Seems reasonable, but are you sure about not wanting sync flow support? https://github.com/Domain-Connect/dc-template-linter/wiki/DCTL1029 |
pawel-kow
requested changes
Feb 25, 2026
Member
pawel-kow
left a comment
There was a problem hiding this comment.
Please fill in the test data in the description.
Member
|
Also "we plan to add syncPubKeyDomain in a follow-up." is just more work for everyone. syncPubKeyDomain is strongly recommended from the start. |
Contributor
Author
|
OK, I've added syncPubKeyDomain and added support for it on my side. I also added the test case as requested. |
Member
|
perfect, now if you have syncPubKeyDomain set, warnPhishing is pointless |
pawel-kow
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Template for webtastic.site web host.
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverChecklist of common problems
Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
syncPubKeyDomainspecified (yes,warnPhishingis an option, but some providers reject such templates by policy, so signing shall be a default)syncRedirectDomainis specified when intended to useredirect_uriparameter in the synchronous flow"v=spf1 ...") instead of using SPFM record type on APEXNot in use
txtConflictMatchingModeis set on TXT records which shall be unique on a label (like DMARC)Not in use
Not in use
hostparameterNot in use
%host%variable inhostattributeNot in use
essentialsetting is used on records, which the user shall be able to change or remove manually later without dropping the whole template (like DMARC)Example variable values
<-- to make review process easier please provide the whole
testDataobject from the Online Editor after testing and using "Add as test" button. Hint: test also with "host" variable set. -->