fix(Desktop): Simplified full-screen/maximize behaviour

[PartyDonut]

Pull Request Description

Cleanup full-screen/maximize behaviour

Issue Being Fixed

Resolves #198

[sourcery-ai]

Reviewer's Guide by Sourcery

The pull request simplifies the logic for handling full-screen and maximize window states. It removes redundant checks and ensures that the window transitions between states correctly.

Sequence diagram for window state transitions

sequenceDiagram
    participant User
    participant TitleBar
    participant WindowManager

    User->>TitleBar: Click maximize button
    alt fullScreen and maximized
        TitleBar->>WindowManager: setFullScreen(false)
        TitleBar->>WindowManager: unmaximize()
    else fullScreen
        TitleBar->>WindowManager: setFullScreen(false)
    else not maximized
        TitleBar->>WindowManager: maximize()
    else maximized
        TitleBar->>WindowManager: unmaximize()
    end

Loading

State diagram for window maximize/fullscreen behavior

stateDiagram-v2
    [*] --> Normal
    Normal --> Maximized: maximize()
    Normal --> Fullscreen: setFullScreen()
    Maximized --> Normal: unmaximize()
    Maximized --> Fullscreen: setFullScreen()
    Fullscreen --> Normal: setFullScreen(false)
    Fullscreen --> Normal: setFullScreen(false) + unmaximize()
    note right of Fullscreen
        If both fullScreen and maximized
        are true, both are disabled
    end note

Loading

File-Level Changes

Change	Details	Files
Simplified full-screen and maximize logic.	Removed redundant checks for full-screen and maximized states. Refactored the logic to use a more straightforward approach for toggling between full-screen, maximized, and normal window states. Ensured that the window transitions correctly between states.	lib/screens/shared/default_title_bar.dart

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#198	Fix the inability to undo fullscreen mode on Windows via the fullscreen button	✅
#198	Ensure consistent window management behavior for fullscreen and maximize states	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @PartyDonut - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Review instructions: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}