Open
Conversation
- Guard all ScreenBrightness calls with platform check to only run on Android and iOS where app-level brightness control works correctly - Call setAutoReset(false) on desktop to prevent the screen_brightness plugin from changing system monitor brightness on focus loss - Applies to video player controls, TV player controls, video player next wrapper, book viewer controls, and both settings providers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
If the screen supports software-based brightness control, the desktop application automatically sets the brightness to minimum when the application loses focus.
As it seem unused, i remove the brightness control on desktop
Issue Being Fixed
Checklist