Update glfw/vulkan backend to use explicit context and add single-threaded multiple context demo.#1
Open
FunMiles wants to merge 5 commits intoDragnalith:docking-explicitfrom
Open
Conversation
Contributor
Author
|
The third commit demoes multi-threaded Vulkan work combined with imgui.
|
Contributor
Author
|
The performance is improved with having a shorter lock on the mutex for main thread job queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, the first commit adds the backend support in glfw/vulkan for multiple contexts to the docking branch.
The second commit changes the demo app to show a running example of three contexts each running a demo-window with docking enabled.
Note that the second diff creates a new class
ThreadWindow. This class will be used almost unmodified in an upcoming demo with multi-threading active. The difference is that in this commit,wait_for_mainwhich runs a functor on the main thread executes directly, as there is only one thread. In the multi-threading demo, that function passes the functor to the main thread and waits until it has finished.