Validating package name - CSIP1#132
Merged
carlwilson merged 5 commits intointegrationfrom Apr 23, 2025
Merged
Conversation
carlwilson
reviewed
Apr 2, 2025
Member
carlwilson
left a comment
carlwilson
left a comment
There was a problem hiding this comment.
There are a couple of pre-commit issues around trailing spaces and similar, see https://github.com/E-ARK-Software/eark-validator/actions/runs/14220300505/job/39846401022. That aside this is good.
Collaborator
Author
|
Updated CSIP1 test and fixed pre commit issues. Please have a look again @carlwilson |
carlwilson
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding checking whether @OBJID is equal to package name - CSIP1.