Open
Conversation
Member
Author
|
@colemanjs FYI |
streeve
force-pushed
the
finite_difference
branch
from
1877c5d to
c2ea6ea
Compare
kwitaechong
reviewed
Jun 1, 2023
| k - planes[b][2], 0 ); | ||
| } ); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
It might be a good idea to add comment about the problem. I think this is about unsteady heat equation problem in 3d.
The governing equstion :
Neumann boundary condition (describing heat flux ) :
There was a problem hiding this comment.
@kwitaechong, you are correct. This boundary conditions is just an adiabatic one. I will correct the description.
Also, it is worth pointing out that I think the left-hand and right-hand sides are swapped...
Member
Author
There was a problem hiding this comment.
@colemanjs can you add a more detailed comment below?
dalg24
reviewed
Jun 22, 2023
| ****************************************************************************/ | ||
|
|
||
| #include <array> | ||
| #include <math.h> |
Collaborator
There was a problem hiding this comment.
Suggested change
| #include <math.h> | |
| #include <cmath> |
dalg24
reviewed
Jun 22, 2023
Co-authored-by: John Coleman <colemanjs@ornl.gov>
streeve
force-pushed
the
finite_difference
branch
from
c2ea6ea to
a70fd5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new example. Use a new directory to differentiate between the tutorial for individual components
TODO: add a link in the wiki somewhere (proxy app page?)