Open
Conversation
Author
|
Note: This includes changes from PR #51 |
remove apple & abieos_static targets
Author
|
remove most of the changes in #51 |
b1bart
suggested changes
Mar 12, 2021
| find_package(Threads) | ||
|
|
||
| add_library(abieos STATIC src/abi.cpp src/crypto.cpp include/eosio/fpconv.c) | ||
| add_library(abieos STATIC src/abi.cpp src/crypto.cpp include/eosio/fpconv.c src/abieos.cpp) |
There was a problem hiding this comment.
The pattern seems to be to only include src/abieos.cpp in the executables that link to abieos and not in abieos.
There is also abieos_module which may be the more appropriate target_link_library for hex_to_json, was that attempted and failed for some reason?
Author
There was a problem hiding this comment.
having in tools/CMakeLists
target_link_libraries(hex_to_json abieos_module ${CMAKE_THREAD_LIBS_INIT})
resulted in
CMake Error at tools/CMakeLists.txt:12 (target_link_libraries):
Target "abieos_module" of type MODULE_LIBRARY may not be linked into
another target. One may link only to INTERFACE, OBJECT, STATIC or SHARED
libraries, or to executables with the ENABLE_EXPORTS property set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
helps debug abi/decoding issues, as well as demonstrates how to build with 'C' api.