replace is_callable_v workaround with is_invocable_v; fixes build on clang12#210
Open
spoonincode wants to merge 1 commit intoeosiofrom
Open
replace is_callable_v workaround with is_invocable_v; fixes build on clang12#210spoonincode wants to merge 1 commit intoeosiofrom
spoonincode wants to merge 1 commit intoeosiofrom
Conversation
Open
12 tasks
|
|
Contributor
Author
|
It would be useful to add a unit test that exercises this code then, as far as I can remember all unit tests did pass with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
is_callable_vworkaround and replaces it withstd::is_invocable_vas the workaround is causing aerror on clang12. Fixes clang12 and also is compiling on gcc8, clang6, and XCode 10.2 -- pretty much the bare minimum for eosio. But, I'm not sure if it's desirable for eos-vm to support a wider range of compilers and the workaround should be fixed instead. Or if I've just completely missed the purpose of this code in the first place... so please review carefully.