Skip to content

test: cover installed Wasm output failures - #1371

Merged
EdamAme-x merged 2 commits into
mainfrom
test/1339-installed-wasm-output
Sep 1, 2026
Merged

test: cover installed Wasm output failures#1371
EdamAme-x merged 2 commits into
mainfrom
test/1339-installed-wasm-output

Conversation

@EdamAme-x

Copy link
Copy Markdown
Owner

Summary

  • extend the real installed Wasm plugin lifecycle fixture with invalid JSON and oversized output cases
  • verify required plugins fail closed with the concrete runtime reason
  • verify optional plugins fail open, preserve the original input, and report the concrete reason
  • keep activation on the real plugins dev build and approval path

Why

The runtime had low-level coverage for malformed and oversized Wasm output, but the complete installed plugin path only exercised traps and fuel timeouts. A packaging, approval, configuration, or startup regression could therefore bypass those guarantees without failing the installation-to-runtime E2E.

Verification

  • python -m py_compile tools/installed_agent_e2e.py
  • git diff --check
  • GitHub Actions plugin lifecycle matrix on Linux, macOS, and Windows

Local full-lifecycle execution in an Arch container reached an unrelated pre-existing Command process-tree assertion before the Wasm phase; it is not claimed as a passing run.

Part of #1339

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 8290ce54-96bd-4849-a679-a0861a715987

📥 Commits

Reviewing files that changed from the base of the PR and between 775c5b5 and db42781.

📒 Files selected for processing (1)
  • tools/installed_agent_e2e.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EdamAme-x
EdamAme-x merged commit 53f5b83 into main Sep 1, 2026
18 checks passed
@EdamAme-x
EdamAme-x deleted the test/1339-installed-wasm-output branch September 1, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant