Skip to content

Allow doubletap of a main screen widget to fullscreen it #6674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CapnBry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow doubletap of a main screen widget to fullscreen it #6674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions radio/src/lua/lua_widget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,12 +274,31 @@ LuaWidget::~LuaWidget()

void LuaWidget::onClicked()
{
if (!fullscreen) {
ButtonBase::onClicked();
if (fullscreen) {
LuaScriptManager::onClickedEvent();
return;
}

LuaScriptManager::onClickedEvent();
// DoubleClick to enter fullscreen mode
constexpr uint32_t DOUBLETAP_TIMEOUT_MS = 500;

uint32_t now = time_get_ms();
if (now - tapLastMs > DOUBLETAP_TIMEOUT_MS) {
tapCount = 0;
}
tapLastMs = now;
++tapCount;

if (tapCount < 2) {
Widget::onClicked();
} else {
onDoubleClicked();
}
}

void LuaWidget::onDoubleClicked()
{
setFullscreen(true);
}

void LuaWidget::onCancel()
Expand Down
3 changes: 3 additions & 0 deletions radio/src/lua/lua_widget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,12 @@ class LuaWidget : public Widget, public LuaScriptManager
int optionsDataRef;
char* errorMessage;
bool refreshed = false;
uint32_t tapLastMs = 0;
uint32_t tapCount = 0;

// Window interface
void onClicked() override;
void onDoubleClicked();
void onCancel() override;
void checkEvents() override;
void onEvent(event_t event) override;
Expand Down