This repository was archived by the owner on Feb 21, 2026. It is now read-only.
Add decodeSwapEvent and decodeLegacySwapEvent functions#3
Open
gasperbr wants to merge 1 commit intoEkuboProtocol:mainfrom
Open
Add decodeSwapEvent and decodeLegacySwapEvent functions#3gasperbr wants to merge 1 commit intoEkuboProtocol:mainfrom
gasperbr wants to merge 1 commit intoEkuboProtocol:mainfrom
Conversation
YohanTz
reviewed
Dec 18, 2025
Comment on lines
+107
to
+108
| const locker = `0x${lockerChunk.toLowerCase()}` as `0x${string}`; | ||
| const poolId = `0x${poolIdChunk}` as `0x${string}`; |
Collaborator
There was a problem hiding this comment.
nitpicking but can we just do like const locker: `0x${string}` = `0x${lockerChunk.toLowerCase()}`; and avoid as for type safety?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.